fix: docker launch method requires proper network resolution#2493
Merged
fix: docker launch method requires proper network resolution#2493
Conversation
Member
Author
|
This should be released asap - it is partially related to the problems observed in ansys/pyansys-workflows#148 Although we might wait for #2487 to be merged too |
RobPasMue
force-pushed
the
fix/docker-launch-method
branch
from
229d702 to
4a730ce
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2493 +/- ##
=======================================
Coverage 94.87% 94.87%
=======================================
Files 169 169
Lines 13884 13884
=======================================
Hits 13172 13172
Misses 712 712 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As title says.. forcing Docker container to be linked to host's default network for proper DNS resolution (either VPN, Google's DNS etc.)
Issue linked
None